Site Editor: Fix All Templates page layout when New admin views is disabled#58039
Closed
t-hamano wants to merge 1 commit into
Closed
Site Editor: Fix All Templates page layout when New admin views is disabled#58039t-hamano wants to merge 1 commit into
t-hamano wants to merge 1 commit into
Conversation
t-hamano
added
[Type] Regression
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Jan 22, 2024
Contributor
Author
|
@ntsekouras @oandregal I noticed that you are re-running unit tests that are failing. Unfortunately, this will require a separate fix... Please see below for details. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue where the canvas is displayed on the All Templates page and the data view is a list layout when the experimental flag "New admin views" is disabled.
Why?
In #57109, the All templates page now uses the data view even if the experimental flag is disabled. However, After #57938, when the experimental flag is disabled, the data view is now displayed as a list layout and unintentionally displays the preview area.
If the experimental flag is disabled, you will not be able to switch to the table layout. It's the intended behavior that the data view is visible, but I think it should be a table layout and the canvas should not be displayed.
How?
Added a conditional statement to determine whether the experimental flag is enabled in template routing.
Note
While working on this PR, I noticed that the sticky header on All Templates page and All Template Parts page were not working. If this is not the intended behavior, I think it needs to be fixed.
Testing Instructions