DataViews: make list layout the default for templates with the experiment enabled#57933
Merged
Conversation
oandregal
added
[Type] Experimental
oandregal
changed the title
|
Size Change: +162 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Contributor
|
I thought that this would be the default for the Templates screen in 6.5, so I'm wondering if it should not be hidden under the experiments? |
Contributor
|
@carolinan We're still trying to assess whether we can make the list view replace the existing screens. The biggest blocker for now is this PR #57938 But both options are still on the table for 6.5.
|
ntsekouras
approved these changes
Jan 18, 2024
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
I guess we can land this and iterate, thanks!
| // Switch to table layout. | ||
| await page.getByLabel( 'View options' ).click(); | ||
| await page.getByRole( 'menuitem', { name: 'Layout' } ).click(); | ||
| await page.getByRole( 'menuitemradio', { name: 'Table' } ).click(); |
Contributor
There was a problem hiding this comment.
Maybe we should start dividing some tests per view..
This was referenced Jan 18, 2024
oandregal
commented
Jan 18, 2024
| }; | ||
|
|
||
| const DEFAULT_VIEW = { | ||
| type: LAYOUT_TABLE, |
Member
Author
There was a problem hiding this comment.
I've got a minimal follow-up #57960
I realized that we may still want to use the table layout when the experiment is disabled ("site editor > templates > manage all templates"), as the list layout is not stable yet.
Contributor
|
Probably not a big deal but a small observation: The 'old' list view is sorted alphabetically which is different to the default sort order for the new one. Should they match (#57114)? It could be good to decide which views (and their configs) to include. IE do we do something like Patterns and provide pre-filtered views additional to the All templates list? This could go some way to mimicking the old template list which is grouped by theme/plugin/custom. Alternatively we look into adding a 'group by field' view option (#57967) and group by author as the default behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
This PR makes the dataviews powered-page the default for the Templates page root.
Before:
Gravacao.do.ecra.2024-01-17.as.19.49.16.mov
After:
Gravacao.do.ecra.2024-01-17.as.19.47.44.mov
Why?
It's the target flow we want.
How?
Testing Instructions