DataViews: add description to pages#57793
Merged
Merged
Conversation
oandregal
requested review from
jameskoster,
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Experimental
|
Size Change: -2.54 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Contributor
|
I've seen comments about avoiding language that alludes to personal ownership to account for different user roles, so perhaps something like:
Still, I'm not entirely convinced about the value this description adds. Is it really needed? Let's ping @WordPress/gutenberg-design for more input. |
Member
Author
This PR adds the text in use by the existing page to the new one. I thought we'd want the same, but happy to iterate on the copy or having no text at all. |
Contributor
|
I did not see any difference from before and after.... Where is the adjustment? EDIT. Edit 2. |
Contributor
I think the inclusion of 'your' in the Pages panel was an oversight. There were a few PRs to remove similar language in other parts of the UI. "Browse and manage pages" seems fine to try. |
Member
Author
👍 Used this for both the stable Pages and the dataviews-powered one. Update the PR description with before/after screenshots as well. |
jameskoster
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #57578
What?
Why?
All root pages have a description and the existing page we aim to replace also has one.
How?
Adds the description to the sidebar component.
Testing Instructions