Fix webpack not setting environment.module true#57714
Merged
Merged
Conversation
sirreal
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
sirreal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Set
output.environment.modules = truein the webpack modules config for wp-scripts. This aligns with the current interactivity webpack config:gutenberg/tools/webpack/interactivity.js
Lines 26 to 34 in 6ef4629
Why?
Webpack (via wp-scripts) may refuse to output external modules unless we set
output.environment.modules = true:Noticed while working on #57712
Testing Instructions
You can test this on #57712. This is currently committed there.
wp-scripts usage without
--experimental-modulesis unaffected.