DataViews: use pages dataviews for the "Pages" section#57589
Closed
oandregal wants to merge 3 commits into
Closed
Conversation
oandregal
requested review from
jameskoster,
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Experimental
This was referenced Jan 5, 2024
oandregal
changed the title
|
Size Change: +20 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/pages-dataviews-as-root
branch
from
f1e50c2 to
22c5b4b
Compare
Member
Author
|
Trying to land this in pieces is creating some weird experiences. Going to switch this to draft and propose we use #57578 to land everything together. It's not too big a PR anyway. |
Contributor
|
Thank you for starting this, it has raised some important questions.
Conceptually the dark sidebar is primarily about navigation and view management, so I'd lean towards placing it in the frame area, similar to templates.
Also the section at the bottom of the list including 404 and search results. It would be good to honor the existing flows – at least initially – so let's include them in the list if possible. One observation is that there are some styling issues around the list items on this PR that I do not see on trunk:
|
youknowriad
reviewed
Jan 8, 2024
| path={ | ||
| window?.__experimentalAdminViews | ||
| ? '/pages' | ||
| : '/page' |
Contributor
There was a problem hiding this comment.
Can we instead keep the url the same and change what's rendered?
Member
Author
|
Closing this one as #57578 has landed. |
This was referenced Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related: #57578
What?
Makes the pages list that uses dataviews the root for the "Pages" section:
Gravacao.do.ecra.2024-01-05.as.13.15.40.mov
Why?
This is the goal. Using in will make evident what's left.
How?
Testing Instructions
TODO
Follow-ups / Related PRs
Questions to address in follow-ups: