PostFeaturedImage: Remove unnecessary 'block-editor' store subscription#57554
Merged
Conversation
Mamaduka
added
[Type] Performance
Mamaduka
commented
Jan 4, 2024
| mediaUpload( { | ||
| allowedTypes: [ 'image' ], | ||
| getSettings().mediaUpload( { | ||
| allowedTypes: ALLOWED_MEDIA_TYPES, |
Member
Author
There was a problem hiding this comment.
I'm just re-using the existing constant here.
|
Size Change: +2 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jan 5, 2024
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Tests well and the code LGTM. 🚀
From what I understand, the performance impact is unmeasurable and purely theoretical, since this removes just a single out of thousands of subscriptions, but it's still a good improvement.
Thanks @Mamaduka! 🙌
| mediaUpload( { | ||
| allowedTypes: [ 'image' ], | ||
| getSettings().mediaUpload( { | ||
| allowedTypes: ALLOWED_MEDIA_TYPES, |
Member
Author
|
Thank you, @tyxla! You're right. This is mostly micro-optimization. It doesn't have a noticeable impact, but practices from the core are often adopted by third parties, so we should try our best 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #57513.
PR removes an unnecessary 'block-editor' store subscription from the
PostFeaturedImagecomponent.Why?
The media
mediaUploadsetting is only used during theonDropFilesevent. We can use a static selector getter and grab the setting only when needed. It's a good practice to avoid store subscriptions when unnecessary.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-01-04.at.20.59.41.mp4