Block Library: Remove store subscriptions from Audio and Video blocks#57449
Merged
Conversation
Mamaduka
added
[Type] Performance
Mamaduka
requested review from
ellatrix,
jorgefilipecosta and
ntsekouras
and removed request for
ajitbohra
|
Size Change: -127 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 2, 2024
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you! There is just a typo in both files.
Member
Author
|
Thank you, Nik! |
Mamaduka
force-pushed
the
remove/audio-video-store-subscriptions
branch
from
ef3a04d to
5172ab7
Compare
This was referenced Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up for #57375 and #57376.
Inspired by #57232.
PR removes store subscriptions from Audio and Video blocks.
Why?
It is a micro-optimization as there are usually few usages of these blocks, unlike text blocks. But it's a good practice to avoid store subscriptions when unnecessary.
How?
isSelectedprop to check multi-selection.Testing Instructions