Block Editor: Combine selectors in the 'BackgroundImagePanelItem' component#57159
Merged
Merged
Conversation
Mamaduka
added
[Type] Performance
|
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in be7dbf9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7248067778
|
ramonjd
approved these changes
Dec 18, 2023
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
LGTM
Tested manually too: setting/uploading/resetting background images work as expected
Contributor
Member
Author
|
Thanks for the testing and reviews, folks 🙇 |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A micro-optimization. PR combines two
block-editorstore subscriptions into one for theBackgroundImagePanelItemcomponent.Why?
Reduces the number of store subscriptions each time the panel is rendered. See #54819 (comment).
Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast