Apply __next40pxDefaultSize to TextControl and Button component in renaming UIs#56933
Merged
Conversation
t-hamano
added
[Type] Enhancement
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: -22 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2775329. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7165476920
|
t-hamano
force-pushed
the
tweak/rename-ui-size-40
branch
from
e9ee928 to
8e3d374
Compare
jasmussen
approved these changes
Dec 11, 2023
jasmussen
left a comment
jasmussen
left a comment
Contributor
There was a problem hiding this comment.
Nice. Can you make the buttons 40px tall too? No blocker, but if you're there at the same time :)
t-hamano
changed the title
Contributor
Author
|
Thanks for the review, @jasmussen!
Makes sense, updated 👍 Block Renaming Modal
Navigation Renaming Modal
Template Renaming Modal
Pattern Renaming Modal and Pattern Renaming Modal via Command Palette
Pattern Category Renaming Modal
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
This PR adds a
__next40pxDefaultSizeto the text control component in actions related to renaming.How?
I made changes in 7 places related to renaming. As for renaming the block, it should have already been changed in #56022, but it looks like it was unintentionally deleted by #56386 (Source 1, Source 2).
Testing Instructions
In the UI below, confirm that the height of the text control is 40px.
Block Renaming Modal
Open the Post Editor > Insert a block > Open the Options dropdown > Rename
Block Advanced Panel
Open the Post Editor > Insert a block > Show block sidebar > Open Advanced panel > Block Name
Navigation Renaming Modal
Open the Site Editor > Navigation Page > Select a navigation > Open the Actions dropdown > Rename
Template Renaming Modal
Open the Site Editor > Patterns page > Create a custom template > Select the template > Open the Actions dropdpwn > Rename
Pattern Renaming Modal and Pattern Renaming Modal via Command Palette
Pattern Category Renaming Modal
Open the Site Editor > Patterns page > Create a pattern with categories > Select the category > Open the Actions dropdpwn > Rename