Fix query block duplicate group block rename controls for WP 6.4#55604
Merged
scruffian merged 13 commits intoOct 26, 2023
Conversation
|
Size Change: +23 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c8c44cf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6638634898
|
getdave
added
[Feature] Blocks
scruffian
approved these changes
Oct 25, 2023
scruffian
left a comment
scruffian
left a comment
Contributor
There was a problem hiding this comment.
One nit, this looks good to me.
mikachan
reviewed
Oct 25, 2023
mikachan
left a comment
mikachan
left a comment
Member
There was a problem hiding this comment.
Thank you for this! Also looks good to me, I've left one inline question.
mikachan
reviewed
Oct 25, 2023
mikachan
left a comment
mikachan
left a comment
Member
There was a problem hiding this comment.
Just noticed that this test failure may be a genuine failure related to these changes.
Contributor
Author
And this is why I wrote good tests for this feature 🎉 Yes we need to reinstate the inspector control to allow renaming. Probably requires re-adding the hook. |
Contributor
Author
|
Note that when this PR merges we will want to create a PR which merges the changes here with those in This could be a relatively complex merge operation due to how |
Contributor
getdave
changed the title
mikachan
approved these changes
Oct 26, 2023
mikachan
left a comment
mikachan
left a comment
Member
There was a problem hiding this comment.
Changes look good to me and tests are happy! 🚢
This was referenced Oct 26, 2023
scruffian
deleted the
fix/query-block-duplicate-group-block-rename-controls
branch
Contributor
|
I've gone ahead to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the repeated
Renamemenu item in the block options menu when the Group block is within a Query Loop block.Fixes #55517
Why?
Because you only want to rename once, rename once, rename once, rename once...
How?
Removes the reliance on
Block.Edithook and instead moves the menu item directly into theBlockSettingsMenuControlsSlot.Why is this ok?
For 6.4 this feature exists only for the Group block. However in Gutenberg
trunkthe feature is enabled for (nearly) all blocks.This means the feature is an integral part of the Editor and so using a hook no longer makes sense. Indeed, we agreed on such an approach in #55250 (comment).
Testing Instructions
lots of31 Posts (I used Fakerpress)Renameoption.wp/6.4branch.Renameis only available for GroupAdvanced -> Rename.Testing Instructions for Keyboard
Screenshots or screencast