Fix/55278 standardize font library rest api#55454
Closed
pbking wants to merge 19 commits into
Closed
Conversation
…ated collection IDs
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ phpunit/data/fonts/DMSans.woff2 ❔ phpunit/data/fonts/Merriweather.ttf ❔ phpunit/data/fonts/cooper-hewitt.woff ❔ phpunit/data/fonts/gilbert-color.otf ❔ phpunit/tests/fonts/font-library/wpFontCollection/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionController/wpRestFontCollectionsController.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/base.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/createItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/deleteItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItem.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/getItems.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/registerRoutes.php ❔ lib/experimental/fonts/font-library/class-wp-font-family.php ❔ lib/experimental/fonts/font-library/class-wp-font-library.php ❔ lib/experimental/fonts/font-library/font-library.php ❔ lib/load.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/__construct.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getData.php ❔ phpunit/tests/fonts/font-library/wpFontFamily/uninstall.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionController/base.php |
|
Size Change: -74 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 329ee7d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6562783153
|
danielbachhuber
left a comment
danielbachhuber
left a comment
Member
There was a problem hiding this comment.
Some initial thoughts based on a cursory review
| @@ -0,0 +1,300 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
This file needs some tests for the unauthenticated and unauthorized scenarios.
| * | ||
| * @covers WP_REST_Font_Families_Controller::delete_item | ||
| */ | ||
| class Tests_Fonts_WPRESTFontFamiliesController_DeleteItem extends WP_REST_Font_Families_Controller_UnitTestCase { |
Member
There was a problem hiding this comment.
Can we consolidate these Tests_Fonts_WPRESTFontFamiliesController_* test classes into one larger WP_Test_REST_Font_Families_Controller class?
Contributor
Author
There was a problem hiding this comment.
I suppose we could... what's the benefit? The create_item tests especially are pretty big and combining them into a single file seems unnecessary. Other tests in the suite are broken similarly. Would you want to consider consolidation of those too?
| * @return WP_REST_Response|WP_Error The updated Font Library post content. | ||
| */ | ||
| public function create_item( $request ) { | ||
| $font_family_data = array( |
Member
There was a problem hiding this comment.
What sort of validation/sanitization do these request arguments need?
| ); | ||
|
|
||
| if ( $request->get_param( 'fontFace' ) ) { | ||
| $font_family_data['fontFace'] = json_decode( $request->get_param( 'fontFace' ), true ); |
Member
There was a problem hiding this comment.
What sort of validation/sanitization does this need?
Contributor
Author
|
closing in leu of #57688 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55278
rest_ensure_responsefor all API responsesWhy?
The original implementation was "non standard" in a number of ways (documented in #55278)
How?
Much of the work was previously accomplished during the attempt to merge this work into WordPress Core for the 6.4 release. Those changes have been ported here (as well as the view changes necessary).
Testing Instructions