Add backgroundImage to the theme json docs for appearanceTools#55376
Merged
andrewserong merged 1 commit intoOct 16, 2023
Merged
Conversation
andrewserong
added
the
[Type] Developer Documentation
andrewserong
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
ryanwelcher
as code owners
Contributor
Author
|
Thanks for the quick review! |
andrewserong
deleted the
update/theme-json-docs-to-mention-background-image
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #54336
Update the theme JSON docs to mention
background: backgroundImageunderappearanceTools.Why?
Over in #53934, I'd updated the
theme-json-living.mdfile, but forgot there was another place to describe the properties opted-into byappearanceTools.How?
Just add a line to the docs.
Testing Instructions
Proofread for typos and accuracy 😄
Testing Instructions for Keyboard
Screenshots or screencast