Block Editor: Subscribe only to block editor store in useBlockSync#55041
Merged
Conversation
tyxla
added
[Type] Performance
|
Size Change: +1 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0e9f2b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6404978106
|
ntsekouras
approved these changes
Oct 4, 2023
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Nice! I'm wondering if this would improve performance noticeably. Thank you!
Member
Author
|
Thank you both 🙌
While I didn't spot any regressions looking at the performance results in CI here, I'm going to keep an eye on the aggregated results in code vitals. |
Contributor
|
Makes sense thank you |
Member
|
Great idea! I also noticed this opportunity but you also implemented it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates an inner subscription inside
useBlockSyncto only subscribe to the block editor store, instead of to all stores.Why?
While doing another quick timeboxing session on #54819 I noticed that we're currently subscribing to all stores in
useBlockSyncwhen syncing back from the block editor store to the controlling entity. However, we're using only the block editor store, so there's no need to subscribe to all other stores.How?
We're just adding the block editor as the store descriptor to subscribe to.
Testing Instructions
Smoke test typing and verify all checks are green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None