Site editor: prune store constants#54585
Merged
Merged
Conversation
ramonjd
added
[Type] Code Quality
|
Size Change: -46 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fcd885e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6231917030
|
ramonjd
force-pushed
the
update/edit-site-store-constants-prune
branch
from
973419c to
bf5e6d3
Compare
andrewserong
approved these changes
Sep 21, 2023
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Looking good!
✅ All replaced hard-coded strings look correct
✅ Removed constants weren't being used anywhere
✅ Template part modal and patterns categories behaviour works as on trunk
LGTM! ✨
mikachan
added
the
Backport to Gutenberg RC
Member
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 0d18f06 |
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Consolidate and prune edit site store constants for template part strings * Rename TEMPLATE_PART_AREA_GENERAL to TEMPLATE_PART_AREA_DEFAULT_CATEGORY
mikachan
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Consolidate and prune edit site store constants for template part strings
Why?
When working on #54484 I noticed that some constants in the edit site store weren't being used.
One was, and I moved it over to a centralized file.
Testing Instructions
Tests should pass. Imports shouldn't break build :)
Create template part modal should work as expected