Site editor: bump the z-index of the rename modal#54277
Merged
Conversation
…dropdown popover component, which is set to 1000000 in the component stylesheet
ramonjd
added
[Type] Bug
ramonjd
requested review from
aaronrobertshaw,
andrewserong and
glendaviesnz
1 task
andrewserong
reviewed
Sep 8, 2023
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Oh, great catch! Just wondering if we should add another entry in _z-index.scss for keeping track, rather than adding 1 to the .components-popover value?
The +1 is unnecessary thanks to document tree order.
…' into update/rename-modal-bump-z-index # Conflicts: # packages/edit-site/src/components/template-actions/style.scss
|
Size Change: -1 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 8, 2023
Contributor
There was a problem hiding this comment.
Nice, thanks for the update!
This is testing well for me and has the right z-index:
Possibly for a follow-up, but I see that there are existing rules for .edit-site-list__rename-modal and .edit-site-template__actions over in components/list/style.scss. Since this adds a stylesheet to template-actions/style.scss, would it be good to co-locate the rules?
gutenberg/packages/edit-site/src/components/list/style.scss
Lines 132 to 144 in 119a279
Not a blocker though, LGTM! ✨
andrewserong
reviewed
Sep 8, 2023
| onClose(); | ||
| } } | ||
| overlayClassName="edit-site-list__rename_modal" | ||
| overlayClassName="edit-site-list__rename-modal" |
Contributor
There was a problem hiding this comment.
Also, I wanted to say, eagle eyes here! I took me a few seconds of staring to see the typo fix 😄
Member
Author
How did I miss that? 🤦🏻 Much better to move the z-index rule to the existing stylesheet. Thank you! I'll do that here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps the rename modal
z-indexto be one higher than the dropdown popover component, which is set to1000000.I noticed this while working on #54271
Why?
So that the rename modal sits above the actions dropdown:
Testing Instructions
Create a custom template and pattern. In the site editor, click on the actions ellipsis in the individual views and rename. Also check the patterns grid.
To ensure that modal hovers over the open dropdown element, reduce the dimensions of your browser.
The modal and its background should be above the dropdown.
Thank you!
Screenshots or screencast