Patterns: Add user pattern categories to post editor inserter patterns tab#53933
Merged
glendaviesnz merged 10 commits intoSep 14, 2023
Merged
Conversation
glendaviesnz
added
[Type] Enhancement
glendaviesnz
changed the title
9 tasks
|
Size Change: +1.99 kB (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d2a48ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6067216650
|
aaronrobertshaw
approved these changes
Aug 28, 2023
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
Contributor
There was a problem hiding this comment.
This is testing as advertised for me.
✅ Unsynced patterns display in appropriate user-created categories
✅ Uncategorized patterns show correctly in Uncategorized
Just one small typo I left a comment on.
glendaviesnz
force-pushed
the
add/pattern-category-filtering-post-editor
branch
from
ca0bc2e to
81ece3c
Compare
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
Contributor
There was a problem hiding this comment.
I've given this another test and still appears to be working as advertised for me. Checked with TT3 & TT2 after it was mentioned the pattern lists showed different patterns between this and trunk.
One question though, was there an explicit decision on whether user-created patterns should appear before theme patterns or not?
Currently, after creating a custom pattern it is displayed at the very bottom of the pattern inserter list. Could that be easier for a user to miss?
Contributor
Author
I have switched it so user patterns appear first - @SaxonF do you have a view on whether this is the best approach? |
Contributor
|
@glendaviesnz makes sense to me |
…d filtering (#54007) Co-authored-by: James Koster <james@jameskoster.co.uk>
Contributor
Author
|
This was merged with some failing tests, but is going into a feature branch which needs rebasing to get the failing tests resolved, so failing tests will be sorted on that branch prior to merging to trunk. |
glendaviesnz
added a commit
that referenced
this pull request
Sep 14, 2023
…s tab (#53933) Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk>
glendaviesnz
added a commit
that referenced
this pull request
Sep 15, 2023
…s tab (#53933) Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk>
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add user pattern categories to the post editor block inserter panel
Why?
With the addition of the ability for users to categorize their patterns they will expect them to be ordered by those categories in the inserter.
How?
Used the new
__experimentalBlockPatternCategoriesblock editor settingThis PR was part of a group of PRs that were merged back into #53835 before being merged into trunk.
A full list of the PRs involved in this work can be found here.
Testing Instructions
UncategorizedcategoryScreenshots or screencast
patterns-cat-editor.mp4