Attempt to fix intermittent e2e test failure#53905
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
youknowriad
added
the
[Type] Automated Testing
youknowriad
force-pushed
the
fix/e2e-test
branch
from
c053547 to
2cedb88
Compare
youknowriad
force-pushed
the
fix/e2e-test
branch
from
2cedb88 to
48d60ee
Compare
|
Flaky tests detected in 48d60ee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5962582248
|
Contributor
Author
|
Hard to tell if this is working but I'm not seeing the failure anymore. I'm tempted to just merge this. |
jorgefilipecosta
approved these changes
Aug 24, 2023
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
Member
There was a problem hiding this comment.
I guess the fix may have an impact on the time tests take to run but let's merge this and see if the problem gets fixed. If the test execution time gets worse we can reanalyze.
Contributor
|
Just to help with context this PR was in response to this test failing way too often: There was some speculation on why this started happening in #53768 (comment). It looks like the change here helped but it'd be nice to actually fix that test. |
Contributor
Author
|
cc @WunderBart in case you have an idea here. For the record, the current PR didn't solve the problem. |
Member
Will take a look shortly. |
Member
|
I tried to debug this but was unsuccessful :( This is the only related issue I could find regarding the error message logged by the test - microsoft/playwright#21210. |
Contributor
|
From the Artifacts capture, it looks like it fails before the first block is inserted. Wishful thinking, but I am trying to do a little testing with #54058 😅
|
Member
This might be due to a test design issue I've noticed, where we initialize a new post (createNewPost) in beforeEach hook and then mark some tests as |
Member
WunderBart
added a commit
that referenced
this pull request
Aug 31, 2023
This reverts commit 5a77e22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #53905 (comment):