Fix typo and add tests for fonts install endpoint

[matiasbenedetto]

What?

• Fix a typo in code: See @anton-vlasenko comment here: Fonts Library: Backend #52704 (comment)
• Add tests to specify when the endpoint should fail with 400 (bad request) error.

Testing Instructions

Run WP_REST_Fonts_Library_Controller_Test PHP unit tests

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts-library/class-wp-rest-fonts-library-controller.php
❔ phpunit/fonts-library/class-wp-rest-fonts-library-controller-test.php

[github-actions]

Flaky tests detected in a775572.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5858180328
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[hellofromtonya]

Assuming I didn't again mess up the formatting for wpcs/phpcs ;), the changes LGTM 👍 Once the CI jobs are all 👍 , ready for merge. Great job @anton-vlasenko and @matiasbenedetto!

[hellofromtonya]

Well boo, seems I further messed up the alignment as WPCS is not happy. Instead of using the GH suggestion tool, I'll pull this PR down and fix it. Working on it now.

[matiasbenedetto]

Thanks for the review!