Enforce PR labels: fully re-enabling the pre-merge check#52990
Merged
Conversation
priethor
added
the
[Type] Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52981
What?
Fully enables the pre-check merge that enforces PR labels so that the check fails if the PR is not fully labeled.
Also improves the error message description linking to all type-related labels in the repository and adds the missing
[Type] Regressionlabel.Why?
After the initial setup of the GitHub action, there were some cases where it didn't work properly, so I made the check exit in a success state in all cases to avoid blocking PRs.
How?
By removing the
exit_type: sucesssetting in the workflow configuration.Testing Instructions
After merging:
Enforce PR labelspre-merge check will fail.