Enforce PR labels: Make PR label checks non-blocking to merge while trying a different GH token setting#52975
Merged
Conversation
priethor
added
the
[Type] Project Management
priethor
added
[Type] Project Management
priethor
changed the title
Contributor
Author
|
Skipping the performance and e2e tests as this only changes GitHub action settings and this should not block other PRs 🙂 |
priethor
added
[Type] Project Management
priethor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52760
What?
The action checking the PR labels is not working properly due to permission issues. This change tries using
${{ secrets.GITHUB_TOKEN }}instead of the default${{ github.token }}as an alternative while making the label checks non-blocking to merge PRs.Why?
As the action is currently failing, it will block PRs from being merged until fixed.
How?
By adding the
exit_type: successproperty to the action settings.