Changelog automation: make Accessibility a top-level section#52900
Merged
Conversation
priethor
added
the
[Type] Project Management
Member
|
Would it make sense to change the name of the label to We are currently using the |
|
Size Change: +851 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Contributor
Author
Indeed, I'm proposing to add the prefix to the label in #52760, which adds automation to enforce all PRs have one and only one type-related label. If/when we rename the labels, I can follow up by updating the changelog generation and the automation linked above to use the renamed labels 🙂 |
bph
approved these changes
Jul 25, 2023
bph
left a comment
bph
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks for persisting
|
Flaky tests detected in 46b5ea8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5671500222
|
priethor
added
[Type] Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes a top-level section for Accessibility so that all accessibility-related PRs are grouped there instead of being a subgroup within enhancements or bugfixes.
Why?
This top-level section is currently done manually to give Accessibility the prominence it deserves in the changelog, so improving the automation makes sense.
How?
By treating the
Accessibility (a11y)label as a type mapping rather than as a feature mapping, with higher precedence than bugfix and enhancements labels. Test fixtures are updated, too.Testing Instructions
Run
npm run test:unit bin/plugin/commands/test/changelog.js. There will be a top-level section (### Accessibilityheading) containing two PRs, whereas before, they appeared under enhancements and bugfixes, respectively.