Update framer-motion to 10.13.0#52804
Merged
Merged
Conversation
pamprn09
approved these changes
Jul 20, 2023
|
Size Change: +239 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 21, 2023
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
This is working well for me! Thanks for addressing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #51894
What?
Updates the
framer-motiondependency to^10.13.0.Why?
There was a bug introduced in
framer-motion@10.12.16that caused our Popovers to crash in the@wordpress/components@25.1.0release, but not in the repo. This is because apparently the npm lockfiles are refreshed in package releases, causing the framer-motion version to be bumped to the buggy 10.12.17 release (#51893).Subsequently, our framer-motion version was soft-pinned to 10.11.x (#51894).
The upstream bug in framer-motion has since been fixed, so we can start updating it again.
Testing Instructions
✅ Tests pass
http://localhost:8888/wp-admin/site-editor.php).