SiteHub: Combine site data selector hooks#52567
Merged
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
Size Change: +16 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5433491. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5532268197
|
glendaviesnz
approved these changes
Jul 13, 2023
glendaviesnz
left a comment
glendaviesnz
left a comment
Contributor
There was a problem hiding this comment.
Tested well for me - all the site hub components still displayed and worked as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A small cleanup for the
SiteHubcomponent. Combines twouseSelecthooks into one.Why?
The first hook was already subscribed to the
corestore, so I don't see a reason to keep two hooks.P.S. I also couldn't find anything in the original PR #47777.
Testing Instructions
Screenshots or screencast