Remove anchor support from dynamic blocks#51288
Merged
Merged
Conversation
aaronrobertshaw
approved these changes
Jun 8, 2023
Mamaduka
approved these changes
Jun 11, 2023
Contributor
Author
|
Note: This PR contains changes to PHP files, but a similar PR has already been merged into the |
Member
nk-o
added a commit
to nk-crew/lazy-blocks
that referenced
this pull request
Jun 30, 2023
add this attribute manually because of this Gutenberg's change WordPress/gutenberg#51288
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Remove anchor support from dynamic blocks * Remove unnecessary codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48232
Fixes: #49382
Fixes: #49578
Related to: #48438
What?
This PR reverts anchor support for dynamic blocks added by #44771.
Why?
In #44771, anchor support was added to dynamic blocks, but static blocks with existing anchor were broken (See #48232, #49382, and #49578). This feature was originally planned to be included in WordPress 6.2, but #48232 was the first to report this issue during the Beta phase. Therefore, by #48592, this feature was excluded in the WordPress 6.2 release.
However, this feature still remains on the Gutenberg plugin, which will be bundled with WordPress 6.3 and will cause similar problems. A solution was attempted in #48438, but we decided to revert anchor support for dynamic blocks in the Gutenberg plugin as well, in order to find a more ideal solution.
How?
Strikes out the changes made in #44771 as is, removing anchor support for a total of 53 dynamic blocks. After #44771 was merged, a new Time To Read block was added. However, this block does not currently support anchor, so it does not need to be considered in this PR.
Testing Instructions
trunkbranch, insert all types of blocks as follows: