Skip to content

Quote: Disable edit as HTML support#49426

Merged
Mamaduka merged 1 commit into
trunkfrom
fix/quote-disable-html-editing
Mar 29, 2023
Merged

Quote: Disable edit as HTML support#49426
Mamaduka merged 1 commit into
trunkfrom
fix/quote-disable-html-editing

Conversation

@Mamaduka

Copy link
Copy Markdown
Member

What?

This a follow-up to #49097 (review).
A similar PRs: #11785 and #39318.

PR disabled HTML editing for the Quote block.

Why?

Editing these wrapper blocks in HTML directly is fragile and prone to breaking the users' content. HTML editing should be left to leaf-blocks.

Testing Instructions

  1. Open a Post or Page.
  2. Insert a Quote block.
  3. Confirm "Edit as HTML" action isn't available in block Options.

Screenshots or screencast

CleanShot.2023-03-29.at.12.15.57.mp4

@Mamaduka Mamaduka requested a review from ntsekouras March 29, 2023 08:21
@Mamaduka Mamaduka self-assigned this Mar 29, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Quote Affects the Quote Block labels Mar 29, 2023
@Mamaduka Mamaduka merged commit 87c7611 into trunk Mar 29, 2023
@Mamaduka Mamaduka deleted the fix/quote-disable-html-editing branch March 29, 2023 09:04
@github-actions github-actions Bot added this to the Gutenberg 15.5 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants