Selectors API: Rename Duotone parent from filters to filter#49360
Closed
aaronrobertshaw wants to merge 1 commit into
Closed
Selectors API: Rename Duotone parent from filters to filter#49360aaronrobertshaw wants to merge 1 commit into
aaronrobertshaw wants to merge 1 commit into
Conversation
2 tasks
Contributor
Author
|
Closing as these changes were absorbed into a single PR cleaning up the Selectors API (#49393). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
filterinstead ofcolor#49340What?
Moves
duotoneselectors underfilterinstead of the pluralfilters.Why?
This is to help bring consistency between all the various locations for duotone e.g. theme.json, block supports, selectors etc. See #49340 for further context.
How?
filterstofilterfilter.duotonefilter.duotoneTesting Instructions
npm run test:unit:php -- --filter WP_Get_Block_CSS_Selector_Testfilter.duotoneas well and be based on this PR.