Theme JSON schema: Add position.sticky and dimensions.minHeight properties to settings#49335
Merged
Conversation
…rties to settings
|
Flaky tests detected in 2706fef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4511342470
|
andrewserong
approved these changes
Mar 26, 2023
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this up @t-hamano, sorry I missed this one in the previous PR. Also, thanks for figuring out reliable testing instructions for it, that's working nicely, and I'll keep this in mind when I go to make future updates to the schema.
LGTM! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
What?
This PR fixes a problem in the theme.json schema where the following two properties in the settings global property cause validation errors (not arrowed error).
settings.position.stickysettings.dimensions.minHeightThis is probably due to the fact that the key is not determined in the
settings>properties.Testing Instructions
Create the following JSON file, specifying the JSON schema changed by this PR.
{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/schema/stiky-minheight/schemas/json/theme.json", "version": 2, "settings": { "position": { "sticky": true }, "dimensions": { "minHeight": true }, "blocks": { "core/group": { "position": { "sticky": true }, "dimensions": { "minHeight": true } } } } }When this file is opened in the code editor, confirm that no validation errors occur for all properties.