Fix flaky Site Editor title e2e tests#49203
Merged
Merged
Conversation
Mamaduka
added
the
[Type] Automated Testing
Member
Author
|
If we're okay with this fix, I will apply the same method to The recent causes of failure look related - https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+test%2Fe2e%2Fspecs%2Fsite-editor%2Ftemplate-part.spec.js. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Mar 21, 2023
kevin940726
left a comment
kevin940726
left a comment
Member
There was a problem hiding this comment.
Makes sense to me, thanks!
There might be more bugs in the canvas that we can look into separately. For instance, clicking on the bottom half of the canvas will not enter the edit mode if the template part is not full size.
aristath
approved these changes
Mar 21, 2023
Member
Author
I'm not a fan of using We should have a separate test confirming that clicking on the |
Member
|
Yeah, I'm not a fan of that either. I mentioned it in the original PR: #47777 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #49019.
PR tries to fix flaky Site Editor title e2e tests by using a URL query argument for entering the edit mode. The test always fails for me when running locally on
trunk.Why?
The
editor.canvas.click( 'body' )turned out to be a flaky method for activating the edit mode. However, we can also force canvas mode since we're already using a URL query argument for selecting templates and template parts.See failure artifacts - https://github.com/WordPress/gutenberg/actions/runs/4467473720.
Testing Instructions
Screenshots or screencast
video.webm