BlockHTML: Use correct type when setting 'html' state onBlur#49191
Merged
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 20, 2023
talldan
left a comment
talldan
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for fixing this!
|
Flaky tests detected in b466de9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4465753087
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the
htmlstate type when setting it on theonBlurevent. It was causing[Object object]to flash briefly in the input field.Props to @talldan for noticing the issue #49097 (comment).
Why?
This was leftover from previous refactoring #18968.
Testing Instructions
Confirm "Edit as HTML" works as before.
Screenshots or screencast
CleanShot.2023-03-20.at.11.25.55.mp4