Playwright: fix request utils for non Docker envs#48206
Merged
Conversation
|
Flaky tests detected in e6f0da3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4230101622
|
kevin940726
approved these changes
Feb 20, 2023
kevin940726
left a comment
Member
There was a problem hiding this comment.
Nice, thanks! Any idea how we can test this?
Member
Author
Member
|
I'm gonna just trust you on that then 😆 . |
4dbe6fe to
e6f0da3
Compare
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
Contributor
|
I just cherry-picked this PR to the wp/6.2 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
For non Docker installs theme activation fails: the path assumes the base URL to be simply the host while WP could be installed in a directory. It also assumes the theme won't be located in a subdirectory.
Extracting this out of #47907 to isolate test failures.
Why?
How?
Testing Instructions
Use MAMP: https://github.com/WordPress/gutenberg/blob/9a4b95e37da8b4c4b271f510895690a4ea1fa780/docs/contributors/code/getting-started-with-code-contribution.md#using-local-or-mamp
Testing Instructions for Keyboard
Screenshots or screencast