Fix site editor navigation#48025
Merged
Merged
Conversation
youknowriad
added
[Type] Bug
youknowriad
requested review from
jameskoster,
jorgefilipecosta and
ntsekouras
|
Size Change: +92 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Feb 13, 2023
jameskoster
left a comment
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
Both issues seem to be fixed:
editor.mp4
ntsekouras
reviewed
Feb 13, 2023
Contributor
|
Cherry-picked this PR to the wp/6.2 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I've noticed some small bugs after #47777
This PR fixes both of these issues.
Testing Instructions
1- Open the site editor
2- Open the "templates" sidebar
3- Create a new custom template
4- You should be redirected properly to the template in edit mode
5- Click the "w" menu brings back the sidebar with the template open on the sidebar.
1- Open the site editor
2- Click "Navigation" in the sidebar
3- Click a page or post from your menu
4- the target page is opened in the site editor