Skip to content

Cherry-pick CLI: Fix the default label to match the documentation#47832

Merged
Mamaduka merged 1 commit into
trunkfrom
fix/cherry-pick-cli-default-label
Feb 7, 2023
Merged

Cherry-pick CLI: Fix the default label to match the documentation#47832
Mamaduka merged 1 commit into
trunkfrom
fix/cherry-pick-cli-default-label

Conversation

@Mamaduka

@Mamaduka Mamaduka commented Feb 7, 2023

Copy link
Copy Markdown
Member

What?

PR updates the default label match documentation and the label mentioned in original PR #40969.

Why?

@ntsekouras discovered that the default label mentioned in the documentation doesn't match the CLI default. We use this command more often during Beta/RC release, so I think this label makes more sense as the dafault.

Testing Instructions

  1. Run cherry-picking command without an argument - npm run other:cherry-pick
  2. Confirm it uses the correct default label.
  3. Cancel the command by typing n.

Screenshots or screencast

CleanShot 2023-02-07 at 17 03 11

@Mamaduka Mamaduka requested review from adamziel and gziolo and removed request for ajitbohra, nerrad and ntwb February 7, 2023 13:08
@Mamaduka Mamaduka self-assigned this Feb 7, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg Developer Experience Ideas about improving block and theme developer experience labels Feb 7, 2023

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you George!

@Mamaduka Mamaduka merged commit 736ace6 into trunk Feb 7, 2023
@Mamaduka Mamaduka deleted the fix/cherry-pick-cli-default-label branch February 7, 2023 13:46
@github-actions github-actions Bot added this to the Gutenberg 15.2 milestone Feb 7, 2023
@ntsekouras

Copy link
Copy Markdown
Contributor

Cherry-picked this PR to the wp/6.2 branch.

@adamziel

Copy link
Copy Markdown
Contributor

Cherry-picked this PR to the wp/6.2 branch.

So meta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Experience Ideas about improving block and theme developer experience [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants