Use tertiary variant on Link Control cancel button #47313
Merged
Merged
Conversation
getdave
added
the
[Feature] Link Editing
This was referenced Jan 20, 2023
Contributor
|
No I meant the tertiary style, not the link variant. CC: @jameskoster |
Contributor
Author
|
Question: the design shows no underline on the button by default. However that is not the default state of the Please advise. |
Contributor
|
We usually pair a primary button with a tertiary button:
It should be no different here. |
Who knew?
getdave
changed the title
Contributor
Author
|
Ah yes thank you 👍 I just realised I was using the |
|
Size Change: -8 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jan 20, 2023
|
Flaky tests detected in f6ce48a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3966517884
|
juanmaguitar
added
the
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Implements feedback in #47309 (comment)
Why?
Must match design in #47310
How?
Use
linktertiaryvariant on button component for Cancel buttonTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast