useControlledValue: let TypeScript infer the return type#46164
Merged
Conversation
ciampo
added
[Type] Enhancement
ciampo
requested review from
brookewp,
chad1008,
mirka,
sarayourfriend and
tyxla
sarayourfriend
left a comment
sarayourfriend
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me 🙂 It is a nice simplification.
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…6164) * useControlledValue: let TypeScript infer the return type * CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refine
useControlledValue's return typeWhy?
The new type makes the hook behave more similarly to a native react hook, avoiding the need for type casting like discussed in #45771 (comment)
How?
setValueto be "whatever is the type of thesetStatefunctionas const, which basically tells TypeScript to interpret the type of the return statement as literally as possible (seeconstassertions)Testing Instructions