[Mobile] - Autocomplete - Fix regression related to the Enter key code#45997
Merged
Conversation
…erter where the enter key would fail to create the block and instead it creates a new Paragraph block
geriux
added
[Status] In Progress
|
|
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
Member
Author
|
E2E tests related to the slash inserter passed correctly in wordpress-mobile/gutenberg-mobile#5280 |
geriux
removed
the
Mobile App - Automation
DaisyOlsen
added
the
[Type] Regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Gutenberg Mobile-> [Mobile] - Autocomplete - Fix regression related to the Enter key code wordpress-mobile/gutenberg-mobile#5280What?
This PR fixes a regression introduced by #45510 where it changed getting the keyboard code from the
keyattribute which is being deprecated in the Web standards tocode.This is related to a previous effort (see #43521) to update the mobile code to this new attribute.
Why?
To fix the functionality of the autocomplete also known as slash inserter.
How?
Now it will add the
codeattribute through thecustomEditableOnKeyDowncallback event.Testing Instructions
/imageand tap on the return key of the keyboardScreenshots or screencast