Autocomplete: Check key events more strictly in IME composition#45626
Merged
Conversation
|
|
t-hamano
added
[Package] Components
t-hamano
requested review from
ciampo and
mirka
and removed request for
ajitbohra
|
Size Change: +20 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
7 tasks
Contributor
Author
|
As discussed below this comment, this PR should not be backported to WP6.1.1 as it needs to be thoroughly tested. |
t-hamano
removed
the
Backport to WP Minor Release
mirka
approved these changes
Nov 11, 2022
mirka
left a comment
mirka
left a comment
Member
There was a problem hiding this comment.
Retested on Mac Chrome/Firefox/Safari, and it works as expected 👍
If you could just add a brief changelog before merging, that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #45496
I would like to see this PR backported to a minor release in addition to #45496.
Sorry for the additional correspondence.
What?
This PR adds logic in the Autocomplete component to strictly check whether an IME composition session is in progress.
Why?
An IME composition issue was also discovered in the FormTokenField component and will be fixed in #45607. However, as this comment suggests, there are some cases that cannot be controlled depending on the combination of OS and browser.
How?
Added event.isComposing to determine if an IME composition session is in progress.
Testing Instructions
This PR requires Japanese input, but can be tested by following the steps below:
/見出しwhich is the Japanese translation of the heading block.enterkey.enterkey again.