Cherry-pick: Making sure to kebab case CSS variables generated from presets#44472
Closed
michalczaplinski wants to merge 1 commit into
Closed
Cherry-pick: Making sure to kebab case CSS variables generated from presets#44472michalczaplinski wants to merge 1 commit into
michalczaplinski wants to merge 1 commit into
Conversation
…1` will become `h-1` (#44406) Adding test coverage
|
Size Change: +7 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Looks like the tests are failing because #43594 is not in the |
michalczaplinski
added
the
[Status] Blocked
Contributor
Looks like it was merged after GB 14.1 RC1 was released, which was the cut-off for automatic JS code backports into Core. |
Contributor
|
Thanks Michal! Per my other comment, I've now cherry-picked 4152d53 (i.e. #44406) manually in order to decouple it from #43594. |
ockham
deleted the
cherry-pick/style-engine-kebabcase-preset-slugs-in-editor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picking Style engine: kebab case preset slugs in the editor into
wp/6.1(note the PR base).This is necessary as the original PR is slated for being backported into the 6.1 Beta 2 release. Normally, this is nowadays done automatically through a cherry-pick script but the #44406 PR had some merge conflicts so had to be cherry-picked manually.