Theme.json: Add default values for settings.spacing.spacingScale#43860
Merged
Conversation
t-hamano
added
[Type] Developer Documentation
t-hamano
force-pushed
the
enhancement/theme-json-spacing-scale-default
branch
2 times, most recently
from
dc0cbe7 to
88f0c11
Compare
t-hamano
force-pushed
the
enhancement/theme-json-spacing-scale-default
branch
from
88f0c11 to
d96277c
Compare
t-hamano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #41527
What?
This PR adds the default value for
settings.spacing.spacingScaleamong the spacing size presets defined in thme.json.Why?
Like many other presets, adding default values will help users set their own values, with auto-completion and validation.
How?
I have defined default values based on the default theme.json values in WordPress 6.1.
Testing Instructions
Create a JSON file that references the JSON schema for this branch, such as:
{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/enhancement/theme-json-spacing-scale-default/schemas/json/theme.json", "version": 2, "settings": { "spacing": { } } }Under the
settings.spacing.spacingScaleproperty, confirm that default values are entered as initial values.For the enum type, verify that the default value is indicated by the code editor.
Screenshots or screencast
4565e5708d5a9a07d7b9de275ab764c9.mp4