Popover: stabilize __unstableShift prop to shift#43845
Merged
Merged
Conversation
ciampo
added
[Feature] UI Components
ciampo
requested review from
ajitbohra,
ellatrix,
fluiddot,
noisysocks and
tellthemachines
as code owners
This was referenced Sep 5, 2022
|
Size Change: +13 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 5, 2022
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Looks good and tests well 👍 Just left a single question-suggestion.
| focusOnMount={ isEditingURL ? 'firstElement' : false } | ||
| __unstableSlotName={ '__unstable-block-tools-after' } | ||
| __unstableShift | ||
| shift |
Member
There was a problem hiding this comment.
Are we intentionally keeping the legacy prop here:
Contributor
Author
There was a problem hiding this comment.
Nope, just a miss in my find-and-replace 🙈
Done in a8421c5
ciampo
added
the
Needs Dev Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev note
See the dev note in #44195
What?
Closes #43191
Stabilize
__unstableShiftby adding a newshiftprop. The unstable prop is marked and deprecated and will be supported until the release of WordPress 6.3Why?
See #43191
How?
shiftprop__unstableShiftprop, while still supporting the legacy prop.__unstableShiftinstances in the repo to useshiftinsteadTesting Instructions
trunk__unstableShiftis not used anymore in the codebase