Cover: Prevent typography support styles from affecting placeholder#43505
Closed
aaronrobertshaw wants to merge 1 commit into
Closed
Cover: Prevent typography support styles from affecting placeholder#43505aaronrobertshaw wants to merge 1 commit into
aaronrobertshaw wants to merge 1 commit into
Conversation
Prevent typography support styles from being applied to the block wrapper when the placeholder is being rendered. Also, making the padding a non-em value so that isn't affected by font-size style.
aaronrobertshaw
added
[Type] Bug
|
Size Change: +71 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Contributor
Author
|
It might be possible that finer-grained control over the selectors used to generate theme.json and global styles might help us avoid those styles affecting the block's placeholder. See #46496. I'll close this PR for now until the selectors API settles. |
johnbillion
deleted the
update/cover-to-prevent-typography-styles-on-placeholder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to:
What?
Prevents typography support styles from applying to the Cover block's placeholder.
Why?
Styling the placeholder's text doesn't really provide any insight to the user as to what their block would look like. It primarily just gets in the way and looks broken.
How?
pxinstead ofemto avoid font size increasing the padding.Todo
emtopxis-placeholderis present.Alternative Approaches Considered
Resetting typographic styles for the placeholder via CSS.
This would work, except that text decoration is rendered differently and can't effectively be reset once it has been applied to a parent. If we have to exclude text decoration styles manually, we might as well strip the others from ever being applied on the block as well.
Testing Instructions
TBA.
Screenshots or screencast
TBA.