Try to fix the popover position when changing to show button text labels#43327
Closed
ntsekouras wants to merge 1 commit into
Closed
Try to fix the popover position when changing to show button text labels#43327ntsekouras wants to merge 1 commit into
show button text labels#43327ntsekouras wants to merge 1 commit into
Conversation
ntsekouras
added
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Aug 17, 2022
| import WritingMenu from '../writing-menu'; | ||
|
|
||
| const MoreMenu = ( { showIconLabels } ) => { | ||
| const anchorRef = useRef(); |
Member
There was a problem hiding this comment.
Must be missing something. Where does this ref get attached?
Contributor
There was a problem hiding this comment.
I was wondering if this one is working specifically because it isn't attached to anything, so it overrides the Popover's default positioning?
Contributor
There was a problem hiding this comment.
Yeah this is unusual, I would also expect this ref to be attached to an element
ellatrix
reviewed
Aug 17, 2022
| showTooltip: ! showIconLabels, | ||
| ...( showIconLabels && { variant: 'tertiary' } ), | ||
| } } | ||
| popoverProps={ { anchorRef: anchorRef?.current?.firstChild } } |
Member
There was a problem hiding this comment.
Why do we need the first child?
Contributor
|
Thanks for the ping. Just linking another potentially related PR in #42971 from @ciampo, which is related to Popover positions, where it attempts to use the parent node if one isn't provided, in order to provide an |
Contributor
|
Thank you for the ping! Without an explicit In this case, though, this menu is using the gutenberg/packages/components/src/dropdown/index.js Lines 111 to 115 in 3c619fd I believe that what's happening on
I see two alternatives:
|
67 tasks
Contributor
I looked a bit more into this, and this is what I believe is happening:
|
Contributor
|
I put together a quick Storybook example for the Kapture.2022-08-18.at.11.29.31.mp4To recap: To fix this bug properly, we would need to:
Otherwise, we could get around the problem in a few ways:
|
Contributor
|
Opened an attempt at fixing the problem directly in the |
johnbillion
deleted the
try/fix-options-popover-when-toggle-show-button-labels-text
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No sure about this one..
Related PR: #41361
Before
before.labels.mov
After
after.labels.mov