Skip to content

Style Engine: Tweak Declarations filtering logic slightly#43215

Merged
andrewserong merged 3 commits into
trunkfrom
update/style-engine-tweak-declarations-filtering-logic
Aug 15, 2022
Merged

Style Engine: Tweak Declarations filtering logic slightly#43215
andrewserong merged 3 commits into
trunkfrom
update/style-engine-tweak-declarations-filtering-logic

Conversation

@andrewserong

Copy link
Copy Markdown
Contributor

What?

Follow up to #43004, to tweak the declarations filtering logic slightly (use wp_strip_all_tags).

Why?

Code quality follow-up and tweaks.

How?

In the filter_declaration method add wp_strip_all_tags before calling safecss_filter_attr

Testing Instructions

Follow testing instructions from #43004 and make sure style output still looks good.

@andrewserong andrewserong added [Type] Code Quality Issues or PRs that relate to code quality [Package] Style Engine /packages/style-engine labels Aug 15, 2022
@andrewserong andrewserong requested a review from ramonjd August 15, 2022 00:59
@andrewserong andrewserong self-assigned this Aug 15, 2022

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch 💟

@andrewserong andrewserong merged commit daa3d57 into trunk Aug 15, 2022
@andrewserong andrewserong deleted the update/style-engine-tweak-declarations-filtering-logic branch August 15, 2022 02:07
@github-actions github-actions Bot added this to the Gutenberg 14.0 milestone Aug 15, 2022
@andrewserong andrewserong added the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Aug 15, 2022
andrewserong added a commit that referenced this pull request Aug 15, 2022
* Style Engine: Tweak Declarations filtering logic slightly
@andrewserong

Copy link
Copy Markdown
Contributor Author

Cherry-picked into the 13.9.0 RC 3 (https://github.com/WordPress/gutenberg/releases/tag/v13.9.0-rc.3)

@andrewserong andrewserong removed the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Style Engine /packages/style-engine [Type] Code Quality Issues or PRs that relate to code quality

Projects

Status: 🏆 Done

Development

Successfully merging this pull request may close these issues.

2 participants