Block Directory: Modernize DownloadableBlockListItem tests#43026
Merged
ciampo merged 1 commit intoAug 8, 2022
Conversation
tyxla
added
[Type] Enhancement
Member
Author
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ciampo
deleted the
update/modernize-downloadable-block-list-item-rtl-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/reactin #42981.Inspired by that work, in this PR we're modernizing some of the existing
@testing-library/reacttests to follow the library's best practices.Why?
Historically, some of the
testing-libraryAPIs have changed over the latest versions, and there are a few best practices recommended by the library, namely:fireEventand using@testing-library/user-eventfor dispatching user events and testing interactions.screenfor queries, rather than the query functions returned byrender()/rerender().Ideally, we should follow those for all tests, and this PR is a step in that direction.
How?
We're using
screeninstead of therender()queries, and@testing-library/user-eventinstead offireEvent().Testing Instructions
Verify tests pass:
npm run test-unit packages/block-directory/src/components/downloadable-block-list-item/test/index.js