Theme.json Schema: add support for button elements#42133
Merged
Conversation
pbking
approved these changes
Jul 5, 2022
pbking
left a comment
Contributor
There was a problem hiding this comment.
Looks and works right to me.
Gave me an opportunity to deep-dive into the schema. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In #40260, we added support for button elements to
theme.json. We now need to update theschemafor theme.json to reflect this accurately.Why?
This improves the developer experience by automatically validating the contents of
theme.json.How?
By including
buttonas one of the properties listed under theelementssection.I copied the way we're already doing this for
core/buttonhere, which has worked in my testing, but I'm not sure if there's a better/more correct way to handle this.Testing Instructions
$schemato point to your local Gutenberg version (follow the instructions from the docs here).elements.buttonand check your IDE doesn't complain. Here is an example:textDecoration).