Components: Fix ComboboxControl post-reset focus#41737
Merged
Merged
Conversation
tyxla
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 15, 2022
draganescu
left a comment
draganescu
left a comment
Contributor
There was a problem hiding this comment.
Works great thanks for the fix 🥳
I wonder, the original intent was to focus theinput in the TokenInput component, did it never work?
Member
Author
I think this was broken in #41216, 13 days ago, when the |
Contributor
|
Thank you both for working on this fix so quickly! I opened #41745 to add an entry to the CHANGELOG for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the autofocus in the
ComboboxControlcomponent that happens after resetting the value.I found this while working on #41733.
Why?
It fixes a bug:
How?
We're now properly referencing the input.
Testing Instructions
npm run storybook:devComboboxControland click on Docs.