Skip to content

Webfonts: increase priority of init hook to account for block reregistration #41569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 2 commits into from
Jun 7, 2022
+6 −1
Merged

Webfonts: increase priority of init hook to account for block reregistration #41569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dff6bf
`gutenberg_register_webfonts_from_theme_json()` calls `WP_Theme_JSON_…
ramonjd Jun 7, 2022
36c897a
Remove evil space
ramonjd Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/experimental/register-webfonts-from-theme-json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,9 @@ function gutenberg_add_registered_webfonts_to_theme_json( $data ) {
return $data;
}

add_action( 'init', 'gutenberg_register_webfonts_from_theme_json' );
// `gutenberg_register_webfonts_from_theme_json()` calls `WP_Theme_JSON_Resolver_Gutenberg::get_merged_data()`, which instantiates `WP_Theme_JSON_Gutenberg()`;
// Gutenberg server-side blocks are registered via the init hook with a priority value of `20`. E.g., `add_action( 'init', 'register_block_core_image', 20 )`;
// This priority value is added dynamically during the build. See: tools/webpack/blocks.js.
// We want to make sure Gutenberg blocks are re-registered before any Theme_JSON operations take place
// so that we have access to updated merged data.
add_action( 'init', 'gutenberg_register_webfonts_from_theme_json', 21 );