Add jest-console typings and convert DateTimePicker tests to TypeScript#40957
Merged
Conversation
noisysocks
added
[Type] Code Quality
noisysocks
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
|
Size Change: +403 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Contributor
|
@sarayourfriend and @sirreal , do you have any thoughts on what would be the best way to add types to |
Member
Author
|
I did a little more Googling and experimenting and am convinced that So what I'm unsure about is where that
|
Contributor
|
I recently added some types and I ended up putting them in the Edit: I've only seen your comment now referencing the |
Member
Author
|
Maybe we could borrow that nomenclature though and use |
ciampo
reviewed
May 10, 2022
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
Code changes LGTM 🚀
Let's see what other folks say re. the jest-console typings — once we're good on those, we can merge.
(also, I may not be able to give this PR another round of reviews as I'll be AFK from tomorrow for a week-ish)
sirreal
reviewed
May 10, 2022
sirreal
left a comment
sirreal
left a comment
Member
There was a problem hiding this comment.
This seems like a good way to type jest-console. It will benefit Gutenberg and external consumers.
Member
Author
|
OK, all done. I'll have to wait until the package is released before I can open a PR in DefinitelyTyped to remove |
noisysocks
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Converts the unit tests for
DateTimePickerto TypeScript.Why?
Continues from #40775 which converted
DateTimePickeritself to TypeScript.How?
Everything was straightforward except for the call to
expect( console ).toHaveWarned().This matcher is added by the
@wordpress/jest-consolepackage. We do not currently have any type declarations for these matchers.It's difficult to convert
@wordpress/jest-consoleto TypeScript or to add JSDoc type annotations to@wordpress/jest-consolebecause it relies onjest.extend()which modifies thejestglobal.So instead I opted to manually write a
.d.tsfile for@wordpress/jest-console. Not sure that this is the best approach, though. One concern is that the type declarations can drift away from what's actually insrc.Testing Instructions
npm run test