Rehabilitate drag gesture in LineHeightControl#38930
Merged
Merged
Conversation
|
Size Change: +10 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
stokesman
added
[Package] Block editor
Member
Interesting, it was working before the I don't necessarily disagree with it not being a preferred mode of adjusting line-height, but I think I'd lean towards the consistency argument more. It would probably be better for user expectations if all NumberControls just had dragging, as long as it wasn't detrimental for any specific case. |
stokesman
force-pushed
the
fix/line-height-control-drag
branch
from
1ab934f to
95c2dd4
Compare
stokesman
changed the title
LineHeightControlLineHeightControl
Contributor
Author
|
Good call @mirka! Indeed, it was due to the library upgrade. I've updated the PR title, description and implementation to restore the drag gesture. |
mirka
approved these changes
Feb 22, 2022
mirka
left a comment
mirka
left a comment
Member
There was a problem hiding this comment.
Very nice, confirmed fixed in Chrome/Firefox/Safari. Thanks!
stokesman
force-pushed
the
fix/line-height-control-drag
branch
from
95c2dd4 to
d6c4cb5
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #37164
LineHeightControlbecame based onNumberControland inherited the latter’s ability to adjust its value via drag gestures. After the library upgrade in #38840, the drag gesture will error and this PR fixes it.Before, block crash when attempting to select line height value
line-height-control-drag-crash.mp4
Error details
The error:
[Error] TypeError: undefined is not an object (evaluating 'action.payload.event.nativeEvent.inputType')Stemming from this statement:
gutenberg/packages/block-editor/src/components/line-height-control/index.js
Lines 63 to 65 in 1d7fa7a
Testing Instructions
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).