Try cascading nav styles through classnames#37473
Merged
Merged
Conversation
tellthemachines
requested review from
TimothyBJacobs,
ellatrix and
spacedmonkey
as code owners
7 tasks
|
Size Change: +792 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks for the PR! To me this feels like a good pragmatic step forward. Justifications in a classname affords the same opportunities inheritance does, but a bit more flexibility and simplicity, I think it works well, and in a quick testing, justifications are working across the board for the navigation block. Nice! Could we change the classnames from |
youknowriad
reviewed
Dec 17, 2021
youknowriad
left a comment
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
This is a great approach. Close to what I had in mind with the "no-filters" approach. 👍
| } | ||
|
|
||
| // Custom properties for layout style cascade: default values. | ||
| --layout-justification-setting: flex-start; |
Contributor
There was a problem hiding this comment.
Can we make these CSS variables more specific to the navigation block or something? They feel a bit too generic.
Contributor
Author
There was a problem hiding this comment.
Done! I prefixed them with "navigation".
Contributor
Author
|
@jasmussen the classnames we're using here are the |
tellthemachines
added
[Block] Navigation
Contributor
|
Sorry about that, and thanks for the pointer! I guess this one just needs a code review and a green light. |
Contributor
|
I think the layout justify classnames are also being removed cc @ntsekouras. |
Contributor
Yes, that PR will be reverted. |
tellthemachines
added a commit
that referenced
this pull request
Dec 21, 2021
* Move layout custom properties to filter. * Try cascading nav styles through classnames * Improve formatting. * Remove hook * Fix PHP lint errors. * More specific variable names
7 tasks
This was referenced Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #37438. Instead of adding custom properties to layout, classnames are added to the navigation block wrapper and custom properties are hooked to those classnames.
I think this is neater than adding the custom properties as inline styles, because this way they live in a single place - the stylesheet - instead of being duplicated across JS and PHP files. Also, we're already generating a couple of the justification classnames anyway, to attach submenu styles.
How has this been tested?
Create a Navigation block; change justification/orientation and verify everything works as expected in both editor and front end.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).