Skip to content

Templates Controller: Add missing 'is_custom' prop #36911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Nov 26, 2021
Merged

Templates Controller: Add missing 'is_custom' prop #36911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
060515b
Templates Controller: Add missing 'is_custom' prop
Mamaduka Nov 26, 2021
aff6095
Add prop only for wp_template
Mamaduka Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/compat/wordpress-5.9/class-gutenberg-rest-templates-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,10 @@ public function prepare_item_for_response( $template, $request ) { // phpcs:igno
'has_theme_file' => $template->has_theme_file,
);

if ( 'wp_template' === $template->type ) {
$result['is_custom'] = $template->is_custom;
}

if ( 'wp_template_part' === $template->type ) {
$result['area'] = $template->area;
}
Expand Down Expand Up @@ -582,6 +586,15 @@ public function get_item_schema() {
),
);

if ( 'wp_template' === $this->post_type ) {
$schema['properties']['is_custom'] = array(
'description' => __( 'Whether a template is a custom template.', 'gutenberg' ),
'type' => 'bool',
'context' => array( 'embed', 'view', 'edit' ),
'readonly' => true,
);
}

if ( 'wp_template_part' === $this->post_type ) {
$schema['properties']['area'] = array(
'description' => __( 'Where the template part is intended for use (header, footer, etc.)', 'gutenberg' ),
Expand Down
3 changes: 3 additions & 0 deletions phpunit/class-gutenberg-rest-template-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ function find_and_normalize_template_by_id( $templates, $id ) {
'type' => 'wp_template',
'wp_id' => null,
'has_theme_file' => true,
'is_custom' => false,
),
find_and_normalize_template_by_id( $data, 'tt1-blocks//index' )
);
Expand Down Expand Up @@ -129,6 +130,7 @@ public function test_get_item() {
'type' => 'wp_template',
'wp_id' => null,
'has_theme_file' => true,
'is_custom' => false,
),
$data
);
Expand Down Expand Up @@ -193,6 +195,7 @@ public function test_create_item() {
'raw' => 'Content',
),
'has_theme_file' => false,
'is_custom' => true,
),
$data
);
Expand Down